Remove unnecessary explicit adapter requires from monkeypatch#5086
Merged
philippthun merged 1 commit intoMay 5, 2026
Merged
Conversation
The sequel_case_insensitive_string_monkeypatch unconditionally required sequel/adapters/postgres and sequel/adapters/mysql2, even though the file is only ever loaded via DBMigrator.apply_migrations after a DB connection is already established (which auto-loads the adapter). Replace the explicit requires with `defined?` guards so each adapter is only patched when actually in use. This avoids loading cross-adapter code unnecessarily and makes tests that reference adapter-specific constants (like Sequel::Postgres::Dataset) fail visibly when the adapter is not loaded, rather than being silently masked.
kathap
approved these changes
May 5, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 5, 2026
Changes in cloud_controller_ng:
- Remove unnecessary explicit adapter requires from monkeypatch
PR: cloudfoundry/cloud_controller_ng#5086
Author: Philipp Thun <philipp.thun@sap.com>
Dependency updates in cloud_controller_ng:
- build(deps): bump rubyzip from 3.2.2 to 3.3.0
PR: cloudfoundry/cloud_controller_ng#5081
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps): bump rake from 13.3.1 to 13.4.2 in /docs/v3
PR: cloudfoundry/cloud_controller_ng#5075
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps): bump nokogiri from 1.19.2 to 1.19.3 in /docs/v3
PR: cloudfoundry/cloud_controller_ng#5074
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps): bump minitest from 6.0.5 to 6.0.6
PR: cloudfoundry/cloud_controller_ng#5077
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps): bump mini_racer from 0.20.0 to 0.21.0 in /docs/v3
PR: cloudfoundry/cloud_controller_ng#5073
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps): bump json from 2.19.3 to 2.19.4 in /docs/v3
PR: cloudfoundry/cloud_controller_ng#5076
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps-dev): bump spring from 4.4.2 to 4.5.0
PR: cloudfoundry/cloud_controller_ng#5078
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- build(deps): bump sequel from 5.103.0 to 5.104.0
PR: cloudfoundry/cloud_controller_ng#5082
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sequel_case_insensitive_string_monkeypatchunconditionally requiredsequel/adapters/postgresandsequel/adapters/mysql2, even though the file is only ever loaded viaDBMigrator.apply_migrationsafter a DB connection is already established (which auto-loads the adapter).Replace the explicit
requireswithdefined?guards so each adapter is only patched when actually in use. This avoids loading cross-adapter code unnecessarily and makes tests that reference adapter-specific constants (likeSequel::Postgres::Dataset) fail visibly when the adapter is not loaded, rather than being silently masked.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests